Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: only use http redirects #2472

Closed
wants to merge 1 commit into from
Closed

core: only use http redirects #2472

wants to merge 1 commit into from

Conversation

julianoes
Copy link
Collaborator

This is an attempt to prevent cURL from being redirected from http to https since we ship without SSL in MAVSDK v2.

@julianoes
core: only use http redirects
1ccee5c 
This is an attempt to prevent cURL from being redirected from http to
https since we ship without SSL in MAVSDK v2.
@julianoes julianoes mentioned this pull request Dec 15, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rayw-dronesense
Copy link
Contributor

Nope,

024-12-16 11:10:22.675 20463-20842 Mavsdk                  com.dronesense.pilot.blue            I  Download file: https://github.com/Gremsy/Vio-Camera-Definition/releases/download/v2.0.3/vio_camera_f1_def.xml using cURL...
2024-12-16 11:10:22.686 20463-20842 Mavsdk                  com.dronesense.pilot.blue            I  Downloading camera definition from: https://github.com/Gremsy/Vio-Camera-Definition/releases/download/v2.0.3/vio_camera_f1_def.xml
2024-12-16 11:10:22.686 20463-20842 Mavsdk                  com.dronesense.pilot.blue            W  Downloading over http instead of https
2024-12-16 11:10:22.761 20463-20671 Mavsdk                  com.dronesense.pilot.blue            W  Received ack for not-existing command: 521! Ignoring...
2024-12-16 11:10:22.800 20463-20671 Mavsdk                  com.dronesense.pilot.blue            W  Received ack for not-existing command: 521! Ignoring...
2024-12-16 11:10:22.864 20463-20667 Mavsdk                  com.dronesense.pilot.blue            W  sending again after 0.502956 s, retries to do: 3  (2502).
2024-12-16 11:10:22.927 20463-20667 Mavsdk                  com.dronesense.pilot.blue            W  sending again, retries to do: 1
2024-12-16 11:10:23.025 20463-20842 Mavsdk                  com.dronesense.pilot.blue            I  Downloaded file, result Success
2024-12-16 11:10:23.025 20463-20842 Mavsdk                  com.dronesense.pilot.blue            D  Successfully loaded camera definition
2024-12-16 11:10:23.025 20463-20842 Mavsdk                  com.dronesense.pilot.blue            E  tinyxml2::Parse failed: Error=XML_ERROR_EMPTY_DOCUMENT ErrorID=13 (0xd) Line number=0

@julianoes
Copy link
Collaborator Author

Fascinating :(, thanks for testing @rayw-dronesense.

@julianoes julianoes closed this Dec 17, 2024
@julianoes julianoes deleted the pr-curl-http-only branch December 17, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianoes @rayw-dronesense